| Test Execution Status | Statistics |
|---|---|
| Passed | 0.000% (0/10) |
| Incident | 0.000% (0/10) |
| Skipped | 0.000% (0/10) |
| Failed | 0.000% (0/10) |
| Requires Manual Checking | 0.000% (0/10) |
| Unknown | 0.000% (0/10) |
| All | 0.000% (0/10) |
| Category | Removed Lines | Inserted Lines | Total |
|---|---|---|---|
| Modified lines executed: | 0.000% (0/6) | 0.000% (0/8) | 0.000% (0/14) |
| Modified lines not executed: | 83.333% (5/6) | 87.500% (7/8) | 85.714% (12/14) |
| Source code lines not instrumented: | 16.667% (1/6) | 12.500% (1/8) | 14.286% (2/14) |
| Execution Name | State |
|---|
| Line | Tests | Difference Output |
|---|---|---|
| diff --git a/dh.c b/dh.c | ||
| index f3ed3882..657b32da 100644 | ||
| --- a/dh.c | ||
| +++ b/dh.c | ||
| @@ -1,4 +1,4 @@ | ||
| 1 | - No equivalent source code line in the reference code can be identified. | -/* $OpenBSD: dh.c,v 1.66 2018/08/04 00:55:06 djm Exp $ */ |
| 1 | - | +/* $OpenBSD: dh.c,v 1.68 2018/09/17 15:40:14 millert Exp $ */ |
| 2 | /* | |
| 3 | * Copyright (c) 2000 Niels Provos. All rights reserved. | |
| 4 | * | |
| @@ -188,15 +188,17 @@ choose_dh(int min, int wantbits, int max) | ||
| 188 | logit("WARNING: no suitable primes in %s", _PATH_DH_MODULI); | |
| 189 | return (dh_new_group_fallback(max)); | |
| 190 | } | |
| 191 | 0 | + which = arc4random_uniform(bestcount); |
| 191 ➡ 192 | ||
| 192 ➡ 193 | linenum = 0; | |
| 193 | 0 | - which = arc4random_uniform(bestcount); |
| 194 | 0 | + bestcount = 0; |
| 194 ➡ 195 | while (getline(&line, &linesize, f) != -1) { | |
| 196 | 0 | + linenum++; |
| 195 ➡ 197 | if (!parse_prime(linenum, line, &dhg)) | |
| 196 ➡ 198 | continue; | |
| 197 ➡ 199 | if ((dhg.size > max || dhg.size < min) || | |
| 198 ➡ 200 | dhg.size != best || | |
| 199 | 0 | - linenum++ != which) { |
| 201 | 0 | + bestcount++ != which) { |
| 200 ➡ 202 | BN_clear_free(dhg.g); | |
| 201 ➡ 203 | BN_clear_free(dhg.p); | |
| 202 ➡ 204 | continue; | |
| @@ -206,9 +208,9 @@ choose_dh(int min, int wantbits, int max) | ||
| 206 ➡ 208 | free(line); | |
| 207 ➡ 209 | line = NULL; | |
| 208 ➡ 210 | fclose(f); | |
| 209 | 0 | - if (linenum != which+1) { |
| 210 | 0 | - logit("WARNING: line %d disappeared in %s, giving up", |
| 211 | 0 | - which, _PATH_DH_MODULI); |
| 211 | 0 | + if (bestcount != which + 1) { |
| 212 | 0 | + logit("WARNING: selected prime disappeared in %s, giving up", |
| 213 | 0 | + _PATH_DH_MODULI); |
| 212 ➡ 214 | return (dh_new_group_fallback(max)); | |
| 213 ➡ 215 | } | |
| 214 ➡ 216 |